-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-1443] Tiling + Slicing + Updating #1374
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1374 +/- ##
==========================================
+ Coverage 92.40% 93.01% +0.60%
==========================================
Files 175 174 -1
Lines 13043 13369 +326
==========================================
+ Hits 12053 12435 +382
+ Misses 990 934 -56
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please also add missing coverage |
samples.append(sample) | ||
last_shape = shape | ||
return format_read_samples(samples, index, aslist) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why aren't we using this function anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function cannot handle the indexing logic for tiled samples, as the whole sample might not be available. Behavior stays same for non-tile samples, the logic is moved to numpy()
.
…into fr_tiling_2
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges
https://activeloop.atlassian.net/browse/AL-1443
Lazy download of tiled sample slices + updating